[Bug 780795] Multiqueue: don't allow dropping SEGMENT_DONE events

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780795

--- Comment #4 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Thiago Sousa Santos from comment #2)
> Review of attachment 349101 [details] [review]:
> 
> Patch seems to make sense but I'm curious on why this happens? Downstream is
> returning EOS in the end of a segment?

Yes, that is exactly what happens, the decoders returns EOS.

> 
> Also, isn't it more readable and faster just to set the variable to false
> instead of doing the if before setting?

Yep, just copy pasted what the GST_EVENT_EOS case was doing, but there's indeed
no point in that if, fixed.

Thanks for the review!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.