[Bug 780904] rtprtxqueue: implement handling of the max-size-time property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780904

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #349241|none                        |needs-work
             status|                            |

--- Comment #1 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 349241:
 --> (https://bugzilla.gnome.org/review?bug=780904&attachment=349241)

This patch is wrong, the GST_BUFFER_TIMESTAMP() is in nanoseconds, not in the
RTP clock. And you can't just use the timestamps, you must convert them to the
running time using the segment. Look at how the queue, aggregator or multiqueue
are doing it.

::: gst/rtpmanager/gstrtprtxqueue.c
@@ +349,3 @@
+
+  /* it needs to work if ts wraps */
+  if (high_ts >= low_ts) {

GStreamer timestamps are 64-bit, they don't wrap-around !

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.