[Bug 776712] vaapih264enc doesn't output AU delimiters

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776712

--- Comment #6 from sreerenj <bsreerenj at gmail.com> ---
Created attachment 349334
  --> https://bugzilla.gnome.org/attachment.cgi?id=349334&action=edit
encoder: h264: Insert AU Delimiter

Note: Don't push this patch since it will break the backward compatibility :)

Insert an AUD as the first NAL of each encoded frame.
Some of the application require Access Unit Delimiter
for decoding the stream.

https://bugzilla.gnome.org/show_bug.cgi?id=776712


Driver fix needed for this. 
https://github.com/01org/intel-vaapi-driver/pull/122/commits/762929b6b6312822fc1c04f52fdef136574508d2

Issue: Unfortunately this is going to break the backward compatibility. Because
the older driver code (with out the above driver fix) has mechanism to insert
anything we push as RawDataHeader. So even if the driver fix is not in place,
the AUD will get inserted , but only after SPS and PPS, irrespective of
how/when we insert AUD from middleware. Which is against the h264
specification: As per specification  "When an access unit delimiter NAL unit is
present, it shall be the first NAL unit. There shall be at most one access
unit delimiter NAL unit in any access unit."

So in nutshell:

1: If we apply the gstreamer-vaapi patch and use latest driver(with the fix
mentioned above): Everything will work as expected and AUD will get inserted as
the first NAL.

2: If we apply the gstreamer-vaapi patch and use the old driver: AUD will get
inserted only after SPS and PPS

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.