[Bug 780948] pluginutils.c assumes GST_GL_HAVE_WINDOW_* are defined

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780948

--- Comment #3 from Scott D Phillips <scott.d.phillips at intel.com> ---
(In reply to Matthew Waters (ystreet00) from comment #2)
> (In reply to Scott D Phillips from comment #1)
> > Created attachment 349317 [details] [review] [review]
> > [PATCH] plugins: Fix usage of GST_GL_HAVE_WINDOW_* defines
> > 
> > When these definitions are false, they are undef in the
> > preprocessor, not a defined value of 0. When they are unset the
> > compile fails with:
> 
> Pretty sure that's not true.  i.e. GST_GL_HAVE_WINDOW_* are always defined
> to either 0 or 1 in gstglconfig.h.

Ah, in that case then I think there's a bug in the meson generation of
gstglconfig.h. Here's part of my gstglconfig.h from a meson build:

> #define GST_GL_HAVE_WINDOW_X11 1
> /* #undef GST_GL_HAVE_WINDOW_COCOA */
> /* #undef GST_GL_HAVE_WINDOW_WIN32 */
> /* #undef GST_GL_HAVE_WINDOW_WAYLAND */
> /* #undef GST_GL_HAVE_WINDOW_ANDROID */
> /* #undef GST_GL_HAVE_WINDOW_DISPMANX */
> /* #undef GST_GL_HAVE_WINDOW_EAGL */

I guess we need to sprinkle some glconf.set('GST_GL_HAVE_WINDOW_...', 0) in the
meson.build there.

I think we still need this change though or something like it, even after
meson's gstglconfig.h is fixed. The vaapi plugin should be buildable without
gstgl at all.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.