[Bug 771291] Encoder: HEVC: Add 10 bit encoding support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Apr 7 09:46:59 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=771291

--- Comment #19 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Scott D Phillips from comment #15)
> Review of attachment 349412 [details] [review]:
> 
> ::: gst-libs/gst/vaapi/gstvaapiencoder_h265.c
> @@ +1439,3 @@
> +  const GstVideoFormat format =
> +      GST_VIDEO_INFO_FORMAT (GST_VAAPI_ENCODER_VIDEO_INFO (encoder));
> +  guint bits_depth_luma =
> 
> small nit: may be a good idea to add the minus8 to the variable name here so
> it's obvious that -8 doesn't need to be applied below.

Agree.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list