[Bug 780442] gtreamer-vaapi render multi video in single pipeline causing videos not killed with vaapisink in wayland

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Apr 7 11:52:37 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=780442

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #349344|none                        |reviewed
             status|                            |

--- Comment #9 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 349344:
 --> (https://bugzilla.gnome.org/review?bug=780442&attachment=349344)

just a nitpick :)

::: gst-libs/gst/vaapi/gstvaapiwindow_wayland.c
@@ +520,3 @@
+  /* Just drop if there's pending frames */
+  g_mutex_lock (&priv->frame_lock);
+  if (g_atomic_int_get (&priv->num_frames_pending) > 0) {

g_atomic_* is, well, atomic. In this case, since it is a single instruction,
there's no need to guard it behind a lock

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list