[Bug 759533] vaapisink: doesn't upload packed formats correctly

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=759533

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #349207|none                        |needs-work
             status|                            |

--- Comment #34 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 349207:
 --> (https://bugzilla.gnome.org/review?bug=759533&attachment=349207)

a couple things

::: gst-libs/gst/vaapi/gstvaapiwindow.c
@@ +64,3 @@
+
+  /* Ensure VPP pipeline is built */
+  if (!window->filter) {

gstreamer-vaapi code generally uses the "early return" idiom ;)

if (window->filter)
  return TRUE;

And save indentation in the next lines :D

@@ +96,3 @@
+  /* Ensure VA surface pool is created */
+  /* XXX: optimize the surface format to use. e.g. YUY2 */
+  if (!window->surface_pool) {

ditto

::: gst-libs/gst/vaapi/gstvaapiwindow_priv.h
@@ +84,3 @@
+  GstVaapiFilter *filter;
+  gboolean has_vpp;
+  gboolean need_vpp;

looking at the following patches, I don't see why this variable is needed in
the base class. It looks to me that it can be held as a local variable inside
the functions or the child classes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.