[Bug 780446] gst_rtp_buffer_ext_timestamp() math is incorrect for big jumps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780446

--- Comment #3 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 348573:
 --> (https://bugzilla.gnome.org/review?bug=780446&attachment=348573)

Actually, can you add a test that does

ext = -1;
gst_rtp_buffer_ext_timestamp(&ext, 1) == 1
gst_rtp_buffer_ext_timestamp(&ext, 2) == 2
gst_rtp_buffer_ext_timestamp(&ext, 1) == 1
gst_rtp_buffer_ext_timestamp(&ext, G_MAXUINT32) == G_MAXUINT32
gst_rtp_buffer_ext_timestamp(&ext, 1) == 1 + G_MAXUINT32
gst_rtp_buffer_ext_timestamp(&ext, 2) == 2 + G_MAXUINT32
gst_rtp_buffer_ext_timestamp(&ext, 1) == 1 + G_MAXUINT32

I'm worried that by removing the G_MAXINT32 comparision with the diff, you
sometimes add an extra wrap-around?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.