[Bug 768248] vaapiencode: Add Encoding region-of-interest (ROI) support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768248

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348979|none                        |needs-work
             status|                            |

--- Comment #35 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 348979:
 --> (https://bugzilla.gnome.org/review?bug=768248&attachment=348979)

::: gst/vaapi/gstvaapiencode.c
@@ +738,3 @@
           (GstTaskFunction) gst_vaapiencode_buffer_loop, encode, NULL);
       break;
+    case GST_EVENT_CUSTOM_DOWNSTREAM:

I wonder if this event should be GST_EVENT_CUSTOM_DOWNSTREAM_OOB (out of band)

@@ +741,3 @@
+    {
+      const GstStructure *s = gst_event_get_structure (event);
+      if (gst_structure_has_name (s, "GstVaapiEncoderRegionOfInterest")) {

I don't know if GstVaapiEncoderRegionOfInterest is a good name. Starting with
the namespace. I am not sure if other encoders could enable ROI.

We need to discuss it with the rest of the community. IMO it should be
something more like  "region-of-interest"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.