[Bug 778337] qtdemux: sample_description_index not evaluated when parsing the stsd-box

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778337

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bilboed at bilboed.com

--- Comment #9 from Edward Hervey <bilboed at bilboed.com> ---
(In reply to Juergen Sachs from comment #7)
> Created attachment 349658 [details] [review]
> Try to implement a workaround to fix the problem
> 
> I'm not really happy with this patch because it duplicates some code parts
> and bumps the code. Additionally when the sample_description_index changes,
> at least one unnecessary (wrong) caps record is sent downstream before the
> correct caps follows. Another lack is, that the patch works for HEVC and AVC
> type media only (this are the only formats used by HbbTV/DASH currently).
> It would be better to extract and separate the stsd-parsing from
> parse_trak() and call the same code from tfhd. But there is a lot of usage
> of other local variables that makes this difficultly.
> Currently we do not have the man-power and the detailed knowledge to dare
> such a deep refactoring/redesign of qtdemux.

Nice work !

As Seungha mentioned, there is a "proper" refactor of the stsd parsing which
you could base your patch on. It might make your patch a lot smaller.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.