[Bug 781218] rtsp-stream: issue when getting EADDRINUSE on bind and only one address is in the pool (alloc_ports_one_family)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781218

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #349728|none                        |reviewed
             status|                            |

--- Comment #1 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 349728:
 --> (https://bugzilla.gnome.org/review?bug=781218&attachment=349728)

::: gst/rtsp-server/rtsp-stream.c
@@ +1314,3 @@
+      if (tmp_rtp > 65534 || ++count > 20) {
+        /* port outside of range or failed 20 times */
+        goto port_error;

This code block is duplicated, maybe add a helper ?

@@ +1318,3 @@
+      /* rtp_socket is already bound to a port, close and allocate another */
+      g_clear_object (&rtp_socket);
+      if (rtp_socket == NULL) {

This check is a no-op, since g_clear_object will always set rtp_socket to NULL.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.