[Bug 777206] dashdemux: mosaic issue for MPEG DASH live streaming due to not updating headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777206

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343607|committed                   |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 343607:
 --> (https://bugzilla.gnome.org/review?bug=777206&attachment=343607)

::: ext/dash/gstdashdemux.c
@@ +1158,3 @@
+        if (dashstream->active_stream &&
dashstream->active_stream->cur_representation) {
+          /* id specifies an identifier for this Representation. The
identifier shall be unique within a Period unless the Representation is
functionally identically to another Representation in the same Period.*/
+          if (!g_strcmp0 (dashstream->active_stream->cur_representation->id,
dashstream->last_representation_id)) {

This actually looks wrong. It will go into this if-branch only if the two
representation IDs are the same (i.e. always), while it should be the other way
around (if the representation changed).

Reverting for now

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.