[Bug 781225] qtdemux: set seqnum to segment event in push mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781225

--- Comment #3 from Wonchul Lee <chul0812 at gmail.com> ---

(In reply to Thiago Sousa Santos from comment #2)
> (I'm assuming you had a typo in your first line push -> pull)

Yes, it was a typo the first line should be push mode, sorry.

> 
> I'm not sure I follow what is the bug here. This is what should happen when
> you send a seek upstream:
> 
> 1) Demux receives a seek, converts it to a new seek for upstream
> 2) Demux sets the new seek with the same seqnum of the original seek
> 3) Source receives the seek and handles it
> 4) Source creates a new segment event with the same seqnum of the seek it
> received (which is the same as of the original seek)
> 5) Demux receives the segment with the same seqnum as the original one.
> 6) Demux forwards its own segment and also copies over the seqnum

Source sent a segment event to Demux with the same seqnum of the seek event
received from Demux. 
The problem occurs in here step 6). 

1.Demux does not refer to the seqnum of the segment event sent by Source in
gst_qtdemux_handle_sink_event().
2. Demux does not keep seqnum of the seek event that it sent for upstream
before.

So Demux generates and sends segment event which has a random seqnum.

> 
> It seems to me that the bug might be in the source not copying the seqnum
> properly. Can you provide more information on the issue you are experiencing?

I had also suspected Source at first, but the seqnum of the event from the
source is all set properly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.