[Bug 781320] adaptivedemux: Don't hold locks when pushing FLUSH_START

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Apr 15 06:19:11 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=781320

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.11.91

--- Comment #4 from Edward Hervey <bilboed at bilboed.com> ---
commit e00be2758528eb4ddb326efe4c261ce3b776a6e5
Author: Edward Hervey <edward at centricular.com>
Date:   Fri Apr 14 18:16:28 2017 +0200

    adaptivedemux: Don't hold locks when pushing FLUSH_START

    Some actions (Qos, reconfigure, ...) might take place before we finish
pushing out flush_start.

    One problem would be that:
    1) The QOS handling in adaptivedemux takes the MANIFEST LOCK
      That QOS event comes from basesink with its PREROLL_LOCK taken
    2) FLUSH_START is sent from adaptivedemux with the MANIFEST_LOCK taken and
the basesink flushing handler needs to take the PREROLL_LOCK

     => deadlock

    https://bugzilla.gnome.org/show_bug.cgi?id=781320

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list