[Bug 780442] gtreamer-vaapi render multi video in single pipeline causing videos not killed with vaapisink in wayland

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780442

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #349933|none                        |reviewed
             status|                            |

--- Comment #13 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 349933:
 --> (https://bugzilla.gnome.org/review?bug=780442&attachment=349933)

::: gst-libs/gst/vaapi/gstvaapiwindow_wayland.c
@@ +320,3 @@
+      gst_vaapi_window_wayland_thread_run, window, &err);
+  if (err) {
+    GST_WARNING ("Failed to start wayland thread: %s", err->message);

here's a memleak :)

g_error_free (err);

@@ +456,3 @@

+  /* Just drop if there's pending frames */
+  if (g_atomic_int_get (&priv->num_frames_pending) > 0)

IMO, we should send, at least, a log warning here. But what we really should do
is to send a QoS event, if it is handled by the pipeline.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.