[Bug 777441] dashdemux: Add support for DASH-IF Trick Modes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777441

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343749|none                        |needs-work
             status|                            |

--- Comment #12 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 343749:
 --> (https://bugzilla.gnome.org/review?bug=777441&attachment=343749)

Can you make the commit messages be:

dashdemux: <max 80 column description>
<blank>
<more description>

::: ext/dash/gstdashdemux.c
@@ +617,3 @@
+
+  for (list =
+      g_list_first (adapt_set_node->RepresentationBase->EssentialProperty);

Don't use g_list_first(something). Just use something.

@@ +656,3 @@
+      trick_adapt_set_node->id, parent_adapt_set_node->id);
+
+  /* TODO */

Please make one patch which adds all parts of this feature (i.e. parsing and
handling of adaptation sets).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.