[Bug 781393] tsdemux: fix to keep seqnum of segment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781393

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #349932|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 349932:
 --> (https://bugzilla.gnome.org/review?bug=781393&attachment=349932)

::: gst/mpegtsdemux/mpegtsbase.c
@@ +203,2 @@
   gst_segment_init (&base->segment, GST_FORMAT_UNDEFINED);
+  base->segment_seqnum = (guint32) 0;

Why the cast?

@@ +216,3 @@
   GST_DEBUG_OBJECT (base, "Streams aware : %d", base->streams_aware);

+  base->segment_seqnum = 0;

Why are you setting it to 0 twice?

::: gst/mpegtsdemux/tsdemux.c
@@ +1721,3 @@
+        if (base->segment_seqnum) {
+          gst_event_set_seqnum (event, base->segment_seqnum);
+          base->segment_seqnum = 0;

Why do you reset it to 0? And there are other places in tsdemux and mpegtsbase
where EOS events are send

@@ +2379,3 @@
   if (!demux->segment_event) {
     demux->segment_event = gst_event_new_segment (&demux->segment);
+    GST_EVENT_SEQNUM (demux->segment_event) = base->segment_seqnum;

gst_event_set_seqnum()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.