[Bug 779245] qtdemux: make sure taglist is writable before adding tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779245

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|---                         |DUPLICATE
   Target Milestone|git master                  |NONE

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks for the patch, sorry it took so long until someone had a look at it.

This issue seems to have been fixed already as part of

commit 642331fd7f5b6236049fbd3b56f2f7f8a71ba174
Author: David Warman <dwarman at manglebit.org>
Date:   Fri Jan 13 12:27:40 2017 +0000

    qtdemux: avoid XMP tag parsing fatal error.

    qtdemux_handle_xmp_taglist() requires a writable taglist,
    but qtdemux->tag_list can become non-writable, specifically
    after sending global tags (qtdemux.c:958), which adds a
    second reference.  Ensure the list is made writable before
    calling (make_writable will copy the list if necessary).

    https://bugzilla.gnome.org/show_bug.cgi?id=766177

modulo the set_scope(GLOBAL) bit which I don't think is correct in this case.

*** This bug has been marked as a duplicate of bug 766177 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.