[Bug 780682] compositor: corrupts output when input caps change while running

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Apr 20 16:17:20 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=780682

George Kiagiadakis <gkiagia at tolabaki.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #349231|0                           |1
        is obsolete|                            |

--- Comment #10 from George Kiagiadakis <gkiagia at tolabaki.gr> ---
Created attachment 350148
  --> https://bugzilla.gnome.org/attachment.cgi?id=350148&action=edit
videoaggregator: delay using new caps from a sink pad until the next buffer in
the queue is taken

I noticed that the previous version of the patch had a bug. If _fill_queues()
returned GST_FLOW_NEEDS_DATA and the timeout variable of
gst_video_aggregator_aggregate() was TRUE, then reconfiguration would not
happen.

This is a fixed version of the patch. I simply don't use the return value from
_fill_queues() to determine if there is need for reconfiguration, I check the
src pad flags instead.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list