[Bug 781577] Fails to play specific size theora files (vaapisink bufferpool issue)

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Apr 24 10:58:04 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=781577

--- Comment #8 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Jussi Kukkonen from comment #6)
> (In reply to Víctor Manuel Jáquez Leal from comment #4)
> > Created attachment 350228 [details] [review] [review]
> > vaapivideobufferpool: create allocator if needed
> > 
> > Sometimes a video decoder could set different buffer pool
> > configurations, because their frame size changes. In this case we
> > did not reconfigured the allocator.
> > 
> > This patch enables this use case, creating a new allocator inside
> > the VAAPI buffer pool if the caps changed, if it is not dmabuf-based.
> > If so, it is just reconfigured, since it doesn't have a surface pool.
> 
> Thanks for the really fast response, much appreciated.
> 
> The patch doesn't fix the issue though: while
> gst_buffer_pool_config_get_allocator() call a little before the patch
> succeeds, 'allocator' is still NULL so the code in the patch is never
> executed.

I worked the patch in master. I didn't back port it to 1.10. Perhaps it would
need more work.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list