[Bug 781904] gtk-play: crashes and gtk api fixes

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Apr 28 15:37:56 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=781904

--- Comment #1 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Created attachment 350655
  --> https://bugzilla.gnome.org/attachment.cgi?id=350655&action=edit
playback/player: don't unref gtk_sink but sink it

Commit 5b8ba60c was added because of a memory leak when gtksink was
used as renderer. Nonetheless the patch didn't consider two facts:

1\ that the gtk_sink element was in floating state
2\ there is another code path where the gtk_sink element is already
   sank

Thus the correct fix, is not to ref and unref gtk_sink, but sink it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list