[Bug 781904] gtk-play: crashes and gtk api fixes

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Apr 28 15:38:02 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=781904

--- Comment #2 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Created attachment 350656
  --> https://bugzilla.gnome.org/attachment.cgi?id=350656&action=edit
playback/player: don't unref a contained widget

In the GTK+ model, when a wiget is created, it is floating, thus
when it is added to a widget container, this container is the owner
of the widget.

The video_area widget is created in two different paths:

1\ when the renderer element is also a GTK+ widget and we are
   the owners.
2\ when the renderer element is an overlay an video area a new
   widget owned by the container.

In the first code path, there was a memory leak fixed on commit
f8d4796a, but it didn't consider the second path, leading to a
segmentation fault because the owner of the widget is not us.

This patch unrefs early the video area widget in the first path
avoiding to unref it twice in the second path.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list