[Bug 785680] New: GstBuffer Flags and io-mode GST_V4l2_IO_USERPTR

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785680

            Bug ID: 785680
           Summary: GstBuffer Flags and io-mode GST_V4l2_IO_USERPTR
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: merlinmanthey at gmx.de
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 356715
  --> https://bugzilla.gnome.org/attachment.cgi?id=356715&action=edit
proposed fix

Hi,

i'm developing a v4l2 camera driver and a propriatary GstPlugin for custom
post-processing. Our driver does sometimes fail to acquire images (for a known
reason) and therefore the current v4l2_buffer flag V4L2_BUF_FLAG_ERROR is set. 

When using the v4l2src with no specific io-mode (I think GST_V4L2_IO_AUTO is
used) the behavior is as expected. The GstBuffer is receive in my plugin has
the flag GST_BUFFER_FLAG_CORRUPTED set whenever the V4L2_BUF_FLAG_ERROR flag is
set.

If i use the io-mode GST_V4l2_IO_USERPTR i never receive the error flag.


I propose to fix this error with the attached patch. I'm not sure if its a good
idea to do it the way i propose. Maybe it would be smarter to transfer only the
error flag ?
Whats your opinion on this ?

Kind regards,
Merlin

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.