[Bug 784827] compositor: Add support for crossfade blending

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784827

Mathieu Duponchelle <mduponchelle1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355378|none                        |accepted-commit_now
             status|                            |

--- Comment #5 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 355378:
 --> (https://bugzilla.gnome.org/review?bug=784827&attachment=355378)

Looking good to me apart from these comments :)

::: gst-libs/gst/video/gstvideoaggregatorpad.h
@@ +71,3 @@
   /* < private > */
   GstVideoAggregatorPadPrivate *priv;
+  union {

Need a comment to explain why a pad may have this set to true.

::: gst/compositor/blend.c
@@ +1032,3 @@
       "video compositor blending functions");

+  gst_compositor_blend_argb = GST_DEBUG_FUNCPTR (blend_argb);

I would suggest making this a separate commit, it's a pretty large unrelated
diff :)

::: gst/compositor/blend.h
@@ +27,3 @@
+ * GstCompositorBlendMode:
+ * @COMPOSITOR_BLEND_MODE_NORMAL: Normal blending
+ * @COMPOSITOR_BLEND_MODE_ADDITION: Alphas are simply added,

I'd call the mode "additive" rather

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.