[Bug 785778] pcapparse: support vlan 802.1q

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 4 06:03:30 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=785778

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #356865|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 356865:
 --> (https://bugzilla.gnome.org/review?bug=785778&attachment=356865)

::: gst/pcapparse/gstpcapparse.c
@@ +377,3 @@
+      if (eth_type == 0x8100) {
+        eth_type =
+            GUINT16_FROM_BE (*((guint16 *) (buf + ETH_MAC_ADDRESSES_LEN +
4)));

You should probably check if you actually have enough data for this

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list