[Bug 785777] rtpsession: Also cache RTX stream caps and send caps

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 4 22:19:10 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=785777

Olivier CrĂȘte <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #356860|none                        |reviewed
             status|                            |

--- Comment #3 from Olivier CrĂȘte <olivier.crete at ocrete.ca> ---
Review of attachment 356860:
 --> (https://bugzilla.gnome.org/review?bug=785777&attachment=356860)

Also if we wanted to support H.323, we'd need different send and receive
codecs.

I'm also not super happy with the RTX specific code in rtpsession, but I can
survive.

::: gst/rtpmanager/gstrtpsession.c
@@ +1540,1 @@
+  if (rtx_payload != -1 && rtx_payload != -1

"rtx_payload != -1 && rtx_payload != -1" .. you seem to have one too many ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list