[Bug 785878] curlhttpsrc: critical warning in class_init

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785878

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357092|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 357092:
 --> (https://bugzilla.gnome.org/review?bug=785878&attachment=357092)

Looks mostly good to me, thanks :)

::: ext/curl/gstcurlhttpsrc.c
@@ +204,3 @@
   http_env = g_getenv ("GST_CURL_HTTP_VER");
   if (http_env != NULL) {
+    gfloat http_version = (gfloat) g_ascii_strtod (http_env, NULL);

Please don't use floats here, just take the string and use strcmp() for the 3
possibilities :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.