[Bug 785923] vaapi encoder: support to seperate QP setting for I/P/B frame

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785923

--- Comment #2 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to sreerenj from comment #1)
> (In reply to Hyunjun Ko from comment #0)
> > Support to seperate QP setting to each I/P/B frame.
> > 2 new properties could be provided for this feature, which might be named as
> > "diff-qp-ip(difference of QP between I and P)" and "idff-qp-ib(difference of
> > QP between I and B)"
> > 
> > Suggestion for the name would be welcome!
> 
> Why diff-qp-FrameTypeX instead of qp-FrameTypeX ??

It's just to be clear to users.

If we allow to set QP value instead of difference, I think we can name just
qp-Frametype. (maybe qp-p and qp-b?)
But imho, value of difference would be simple for user.

Example pipeline of what I thought:
raw data ! vaapih264enc (init-qp=26) diff-qp-ip=-2 diff-qp-ib=-3 ! fakesink
same as
raw data ! vaapih264enc (init-qp=26) qp-p=24 qp-b=23 ! fakesink

But if we think documentation would be enough, we can use qp-ip and qp-ib for
the value of difference like the below:
raw data ! vaapih264enc (init-qp=26) qp-ip=-2 qp-ib=-3 ! fakesink

So do you mean you prefer the last one?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.