[Bug 785991] rtpstats: fix unsigned integer comparisons.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785991

Mathieu Duponchelle <mduponchelle1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357184|0                           |1
        is obsolete|                            |

--- Comment #2 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Created attachment 357185
  --> https://bugzilla.gnome.org/attachment.cgi?id=357185&action=edit
rtpstats: fix unsigned integer comparisons.

Callers of the API (rtpsource, rtpjitterbuffer) pass clock_rate
as a signed integer, and the comparison "<= 0" is used against
it, leading me to think the intention was to have the field
be typed as gint32, not guint32.

This led to situations where we could call scale_int with
a MAX_UINT32 (-1) guint32 as the denom, thus raising an
assertion.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.