[Bug 785967] videoenc/dec : delay input buffers allocation until first buffer is received

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785967

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357155|none                        |needs-work
             status|                            |

--- Comment #14 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 357155:
 --> (https://bugzilla.gnome.org/review?bug=785967&attachment=357155)

Looks good, just one nitpick.

::: omx/gstomxvideoenc.c
@@ +1005,2 @@
 static gboolean
+configure_input_buffer (GstOMXVideoEnc * self)

To be consistent, we should keep the namespace here. It's also easier for
debugging, as it prevents having function name clash.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.