[Bug 773660] decklinkvideosink: Feature Request - Hardware Keying
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Aug 10 07:43:35 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=773660
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #357322|none |needs-work
status| |
--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 357322:
--> (https://bugzilla.gnome.org/review?bug=773660&attachment=357322)
Please attach it in "git format-patch" format, or use git-bz :) And include a
proper commit message
Apart from that and some minor things this looks good, thanks :)
::: sys/decklink/gstdecklink.cpp
@@ +322,3 @@
+{
+ BMDKeyerMode format;
+ GstDecklinkKeyerMode gstformat;
Not really "format", more like "mode" and "gstmode" maybe
@@ +1236,3 @@
+ {
+ GST_WARNING
+ ("selected device does not have a keyer interface: 0x%08x", ret);
This should probably only be a warning if keying is actually enabled later
::: sys/decklink/gstdecklinkvideosink.cpp
@@ +417,3 @@
+ {
+ self->output->keyer->Enable (true);
+ self->output->keyer->SetLevel (255);
Maybe the level should also get a property?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list