[Bug 786051] glupload: EGLImage cache is not thread safe

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Aug 10 23:41:23 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=786051

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julien.isorce at gmail.com

--- Comment #1 from Julien Isorce <julien.isorce at gmail.com> ---
I thought a moment we could use gst_memory_lock (mem, GST_LOCK_FLAG_EXCLUSIVE)
? but in fact it is a try-lock.

Can we guard that for loop (around get_cache/set_cache) with
gst_gl_display_lock/unlock ? This should be the same GstGLDisplay instance
since it is per pipeline if I am correct.

Or using gst_memory_share somehow ? So that all memories going out of the tee
are not the same GstMemory instances as the input. It solves the race while not
using a global lock. It will create much more eglimage but these are just
references of the same underlying memory.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list