[Bug 786135] vpxenc: negotiate once, from handle_frame.

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 11 00:31:05 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=786135

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357364|none                        |reviewed
             status|                            |

--- Comment #2 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 357364:
 --> (https://bugzilla.gnome.org/review?bug=786135&attachment=357364)

Why do you need to move that code to handle_frame?

::: ext/vpx/gstvpxenc.c
@@ +1881,3 @@
+    gst_video_codec_state_unref (output_state);
+
+    vpx_enc_class->set_stream_info (encoder, caps,
&encoder->input_state->info);

encoder->negotiated = gst_video_encoder_negotiate (GST_VIDEO_ENCODER
(encoder)); ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list