[Bug 773660] decklinkvideosink: Add support for hardware keying

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773660

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357375|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 357375:
 --> (https://bugzilla.gnome.org/review?bug=773660&attachment=357375)

::: sys/decklink/gstdecklink.cpp
@@ +1236,3 @@
+    {
+      GST_WARNING
+        ("selected device does not have a keyer interface: 0x%08x", ret);

Instead of warning here ...

::: sys/decklink/gstdecklinkvideosink.cpp
@@ +421,3 @@
+  /* enable or disable keyer */
+  if (self->keyer_mode == bmdKeyerModeOff)
+    self->output->keyer->Disable ();

... you check if ->keyer == NULL and warn here if mode!=off

This would currently crash instead

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.