[Bug 785951] urisourcebin/decodebin3: Don't use custom EOS events
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Aug 11 08:20:35 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=785951
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #357276|none |needs-work
status| |
--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 357276:
--> (https://bugzilla.gnome.org/review?bug=785951&attachment=357276)
Looks good to me except for two minor problems
::: gst/playback/gstdecodebin3-parse.c
@@ +272,3 @@
+ s = gst_event_writable_structure (event);
+ gst_structure_set (s, "decodebin3-custom-eos", G_TYPE_BOOLEAN,
TRUE,
+ NULL);
You probably want to take over the seqnum of the input event
::: gst/playback/gsturisourcebin.c
@@ +1444,3 @@
+ s = gst_event_writable_structure (event);
+ gst_structure_set (s, "urisourcebin-custom-eos", G_TYPE_BOOLEAN, TRUE,
+ NULL);
And here
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list