[Bug 785712] FEI: Implement VAEntryPointFEI based h264 encoder

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785712

--- Comment #4 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #3)
> I have been reviewing the code and it is quite messy. I would not like to
> merge it until I reviewed and fixed it. Otherwise it will be a maintenance
> nightmare.

HI Victor,
Thanks for reviewing.

Few of the things which could be helpful while reviewing:

1: It might be difficult to get the full picture of this code until we sort of
the implementation of PreEnc functionality (I am working on this).

2: There is code redundancy (for eg: both ENC only and PAK only abstracts, some
structures like GstVaapiFeiInfoToPakH264 etc).But this is based on required
future development.
a) Stuff Custom BRC algorithm in the ENC+PAK mode
b) There is a useful transcoding scenario. We can extend the *decoder* to
output MVs and a different form of MBCode so that there is a possibility to do
second transcoding with out doing VME.
3) a pipeline like this vaapih264feienc fei-mode=ENC ! vaapih264feienc
fei-mode=PAK

I would prefer an incremental approach, get the initial code base in (with low
ranked element of course) then work on this to improve.


Let's talk in IRC :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.