[Bug 732266] vaapidecode: h264: add support for decoding SVC base layers only

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=732266

sreerenj <bsreerenj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358041|none                        |reviewed
             status|                            |

--- Comment #33 from sreerenj <bsreerenj at gmail.com> ---
Review of attachment 358041:
 --> (https://bugzilla.gnome.org/review?bug=732266&attachment=358041)

::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
@@ +1793,3 @@

+  if (priv->base_only && !GST_H264_IS_MVC_NALU (&pi->nalu))
+    result = gst_h264_parse_sps (&pi->nalu, sps, FALSE);

Why does it only for SVC? svc and mvc base-only mode should behave similarly.
right?

@@ +1941,3 @@
   GST_DEBUG ("decode subset SPS");

+  /* Don't replace. Could overwrite needeed SPS's. */

Bit confused with this comment. I understood that in base-only case, we don't
have to store the subset_sps. But when can this "Overwrite needed sps" happen?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.