[Bug 732266] vaapidecode: h264: add support for decoding SVC base layers only

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=732266

--- Comment #35 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Orestis Floros from comment #34)
> Created attachment 358103 [details] [review]
> libs: decoder: h264: decode SVC base view only
> 
> (In reply to sreerenj from comment #33)
> > Review of attachment 358041 [details] [review] [review]:
> >
> > ::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
> > @@ +1793,3 @@
> >
> > +  if (priv->base_only && !GST_H264_IS_MVC_NALU (&pi->nalu))
> > +    result = gst_h264_parse_sps (&pi->nalu, sps, FALSE);
> >
> > Why does it only for SVC? svc and mvc base-only mode should behave
> > similarly. right?
> 
> I don't know how I missed it, this part is buggy and breaks MVC streams with
> base-only=TRUE right now. This patch should do it.
> 
> I don't know why they behave differently here, I made the distinction
> through trial and error.

Hm, we need an explanation other than trial-and-error-fix-this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.