[Bug 785917] vaapi: h264/h265: support MB(Macroblock) bitrate control

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785917

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357088|none                        |needs-work
             status|                            |

--- Comment #4 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 357088:
 --> (https://bugzilla.gnome.org/review?bug=785917&attachment=357088)

Adding this property in the base case all the encoders will expose it, though
only H264 and H265 handle it. Is this something that we want? if so, why it is
not set in gst_vaapi_encoder_reconfigure_internal() for all the encoders?

::: gst-libs/gst/vaapi/gstvaapiencoder.c
@@ +159,3 @@
+   * GstVaapiEncoder:mbbrc:
+   *
+   * Macroblock level bitrate cotnrol.

typo: control

@@ +166,3 @@
+      g_param_spec_uint ("mbbrc",
+          "Macroblock level Bitrate Control",
+          "Macroblock level Bitrate Control (0: auto, 1: on, 2: off)", 0, 2,

I prefer an enum type for this ON/OFF/AUTO

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.