[Bug 786740] appsink: should not keep a ref on the preroll buffer if belongs to a pool

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Aug 24 09:53:03 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=786740

--- Comment #2 from Julien Isorce <julien.isorce at gmail.com> ---
It is not to address a hang issue here (though it could happen in some
situation). It is just that the buffer does not return to its pull while the
pipeline is playing. There could be no problem about it but it just looks
wrong. And I suspect appsink->preroll_buffer was designed without buffer pool
consideration in the first place.

For example: if a buffer pool is configured with min=max=N buffers then the
pool will iterate over N-1 buffers since one is kept all the time by
appsink->preroll_buffer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list