[Bug 786740] appsink: should not keep a ref on the preroll buffer if belongs to a pool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786740

--- Comment #5 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Tim-Philipp Müller from comment #1)
> Weird, why do we hang onto the preroll buffer even after EOS and/or after we
> start playing?

Yes strange. It behaves like this since its initial implementation
dd72f88a8c56126a0b74e98b35151c6d124b9ade. At least appsink should clear its
local ref once the app has pulled it out, like for other samples. But pb
remains if the app does not care about the preroll buffer since it can get it
from the pull-sample callback anyway.

> 
> Patch looks fine to me (if we need/want to support this).

Oki thx. I think it improves the situation at minimum while not breaking any
existing app that would need to pull the preroll buffer again. Let me know if I
can push it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.