[Bug 732266] vaapidecode: h264: add support for decoding SVC base layers only

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=732266

--- Comment #46 from Orestis Floros <orestisf1993 at gmail.com> ---
(In reply to sreerenj from comment #45)
> (In reply to Orestis Floros from comment #44)
> > (In reply to sreerenj from comment #43)
> > > If we already removed subset_sps and considering only base layer, none of
> > > the slice header should reference to subset_sps.
> > 
> > But we don't remove subset sps's before parsing them, without the check
> > h264parser's nalparser is updated.
> 
> 
> IIRC, you were handling this stuff in your h264parse by invoking the parse
> api without nalparser.  Why can the same be utilized here(if you have to
> parse the subset_sps)?

Yes, this is what I am doing here too. For SVC subset sps I only call
gst_h264_parse_sps() that doesn't use the nalparser. The problem is (from
comment #33) that I don't do that for MVC streams because they don't play
nicely with this for some reason (as I mention in comment #42).

> > > Here the non-base view having field macroblocks.
> > > If the slice heder in base view still reference to the non-base view nals
> > > (subset-sps or pps) , there could be two possible reasons:
> > > 
> > > 1: nalparser override the sps with subset sps since both have the same id.
> > > Or
> > > 2: stream is wrongly encoded
> > 
> > Yes, (1.) is true, forgot to mention it.
> Then the ideal fix should go into h264parse I believe :)

This boils down to what you said in comment #39, right?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.