[Bug 786561] baseparse: excessive tag updates - totem uses about a quarter more CPU than "gst-play-1.0 --videosink=clutterautovideosink"

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786561

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.13.1

--- Comment #24 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
commit 39e21bb6dd79e467ff747ab93b19078f03d03646
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Thu Aug 24 16:00:42 2017 +0100

    baseparse: fix taglist update spam

    We would constantly re-post the taglist because
    posted_avg_rate only gets set to avg_bitrate if
    parse->priv->post_avg_bitrate is true, so if it's
    false the posted rate will always differ from the
    current average rate and we'd queue an update,
    which leads to us spamming downstream and the
    application with taglist updates.

    Fix this by only queuing an update if the average
    rate will actually be posted.

    These taglists updates could cause expensive
    operations on the application side, e.g. in Totem.

    https://bugzilla.gnome.org/show_bug.cgi?id=786561

Should be okay to also pick into 1.12 branch, but let's give it some timer in
master first.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.