[Bug 732266] vaapidecode: h264: add support for decoding SVC base layers only

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 25 20:59:50 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=732266

sreerenj <bsreerenj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358431|none                        |reviewed
             status|                            |

--- Comment #51 from sreerenj <bsreerenj at gmail.com> ---
Review of attachment 358431:
 --> (https://bugzilla.gnome.org/review?bug=732266&attachment=358431)

::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
@@ +4716,3 @@
   pi->flags = flags;
+  if (!priv->base_only || pi->nalu.type != GST_H264_NAL_PREFIX_UNIT)
+    gst_vaapi_parser_info_h264_replace (&priv->prev_pi, pi);

For a base-only use case, why shouldn't we treat both prefix_nal and slice_ext
in a similar way?
Here both slice_ext and prefix_nal are set for SKIP. But slice_ext still get
stored in prev_pi??

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list