[Bug 730758] tee: Handle ALLOCATION query

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=730758

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Julien Isorce from comment #9)
> Review of attachment 357284 [details] [review]:
> 
> Should you remove "alloc-pad" property ? (seems to be mark unused anyway)

It seems that I forgot to attach it, but I have a patch that deprecate it
instead as removing it would be an API break.

> 
> Maybe add a unit test in gstreamer/tests/check/elements/tee.c ? At least one
> and then we can add more.

I'll do.

> 
> ::: plugins/elements/gsttee.c
> @@ +730,3 @@
> +      gst_allocation_params_init (&ctx.params);
> +
> +
> 
> Should it ignore not linked pads if allow-not-linked is true ?

I think this is difficult to implement since gst_pad_peer_query() returns a
boolean rather then GstFlowReturn. Though, GstPad return TRUE when it gets a
query on unlinked pads, which makes the code behave like if allow-not-linked
was set. I'm not sure if it should (I even doubt it should) behave differently
for the other case. I'm tempted to leave it this way.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.