[Bug 732266] vaapidecode: h264: add support for decoding SVC base layers only

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Aug 27 23:25:00 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=732266

--- Comment #59 from Orestis Floros <orestisf1993 at gmail.com> ---
Created attachment 358538
  --> https://bugzilla.gnome.org/attachment.cgi?id=358538&action=edit
libs: decoder: h264: decode SVC base layer only

(In reply to sreerenj from comment #58)
> (In reply to Orestis Floros from comment #57)
> > Created attachment 358495 [details] [review] [review]
> > libs: decoder: h264: decode SVC base layer only
> >
> > (In reply to sreerenj from comment #56)
> > > Review of attachment 358457 [details] [review] [review] [review]:
> > > Nice, This solution is clean.
> > > Can you add few lines of explanation in the commit message?
> >
> > Tell me if you want to move some of these as comments inside the code or if
> > I am being too verbose.
>
> Always prefer to have more comments inside the code, and a good enough
> commit message too. Personally I don't mind even if it is too long :)

Ok, I added some.

I actually found out that most of the process in gst_vaapi_decoder_h264_parse()
can be skipped. This should be a bit more efficient and also only adds a block
of code in gst_vaapi_decoder_h264_parse() instead of multiple changes.

I think it's preferable.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list