[Bug 786561] baseparse: excessive tag updates - totem uses about a quarter more CPU than "gst-play-1.0 --videosink=clutterautovideosink"

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786561

--- Comment #29 from Bastien Nocera <bugzilla at hadess.net> ---
(In reply to Daniel van Vugt from comment #28)
> In that case, your idea from comment #13 should probably be implemented in
> totem:
> 
> "complain a bit louder when the decoder constantly sends signals without
> actual changes."
> 
> I understand you want to expose mistakes in other components, but leaving
> totem fragile and vulnerable to them isn't ideal. If the bug were to happen
> again there is no guarantee another person would come along and diagnose it
> again any time soon. Such a regression could linger indefinitely (again).

Writing a regression test case for GStreamer would be a good way to avoid this
problem appearing again.

This code now throws a GStreamer warning when the problem happens, which should
make it a bit more visible:
commit 2f2230b6da805b7aa31794c6b49929369865176a
Author: Bastien Nocera <hadess at hadess.net>
Date:   Mon Aug 28 13:01:46 2017 +0200

    backend: Warn when tag updates are sent with no changes

    When tag updates are sent but no tags changed, we end up constantly
    changing bits of UI, and eating CPU for no actual change.

    Warn loudly when this happens so that culprits can be fixed.

    See https://bugzilla.gnome.org/show_bug.cgi?id=786561

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.