[Bug 732266] vaapidecode: h264: add support for decoding SVC base layers only

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=732266

--- Comment #68 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Orestis Floros from comment #67)
> By the way, isn't the code in gstvaapidecoder_h264.c:4589
> 
> > if (priv->is_avcC)
> >   result = gst_h264_parser_identify_nalu_avc (priv->parser,
> >       buf, 0, buf_size, priv->nal_length_size, &pi->nalu);
> > else
> >   result = gst_h264_parser_identify_nalu_unchecked (priv->parser,
> >       buf, 0, buf_size, &pi->nalu);
> > status = get_status (result);
> 
> dangerous in the same way? If h264parser fails to parse them and they have
> garbage data (eg as with the PPS case you mention) it can lead to a segfault
> in _finalize() which is called after goto exit IIUC.
> 

There is nothing to do with what h264pasr has been parsed or not.
But yes, there is a possibility to crash in this scenario since we are not zero
initializing the parser_info. Easy fix for this is to use
gst_vaapi_mini_object_new0() instead of gst_vaapi_mini_object_new() for
GstVaapiParserInfoH264 creation.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.