[Bug 786991] gtkglsink: add "rotate-method" property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786991

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358731|none                        |needs-work
             status|                            |

--- Comment #4 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 358731:
 --> (https://bugzilla.gnome.org/review?bug=786991&attachment=358731)

Looks mostly ok.

::: ext/gtk/gstgtkglsink.c
@@ +392,3 @@
+        if (!g_strcmp0 ("rotate-0", orientation))
+          gtk_gst_gl_widget_set_rotate_method (GTK_GST_GL_WIDGET
+              (gst_gtk_base_sink_acquire_widget (GST_GTK_BASE_SINK (sink))),

Erm, could you retrieve the widget earlier and make this line (and subsequent
lines) a lot shorter please.

::: ext/gtk/gtkgstglwidget.c
@@ +31,3 @@
+#include <gst/video/gstvideoaffinetransformationmeta.h>
+#include <gst/gl/gstglutils.h>
+#include <gst/gl/gstglutils_private.h>

Private header.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.