[Bug 785434] omx: add H265 support on Zynq UltraScale+

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785434

--- Comment #9 from Guillaume Desmottes <gdesmott at gnome.org> ---
Review of attachment 358675:
 --> (https://bugzilla.gnome.org/review?bug=785434&attachment=358675)

::: omx/gstomx.c
@@ +2308,3 @@
       , gst_omx_theora_dec_get_type
 #endif
+#ifdef USE_OMX_TARGET_ZYNQ_USCALE_PLUS

indeed. Fixed.

::: omx/gstomxh265enc.c
@@ +90,3 @@
+#ifdef USE_OMX_TARGET_ZYNQ_USCALE_PLUS
+  g_object_class_install_property (gobject_class, PROP_PERIODICITYOFIDRFRAMES,
+      g_param_spec_uint ("periodicty-idr", "Target Bitrate",

The spec defines OMX_VIDEO_CONFIG_AVCINTRAPERIOD which is AVC specific so
Allegro defined its own extension for it.

@@ +98,3 @@
+
+  g_object_class_install_property (gobject_class, PROP_B_FRAMES,
+      g_param_spec_uint ("b-frames", "Number of B-frames",

No, the spec API is AVC specific: OMX_VIDEO_PARAM_AVCTYPE.

@@ +268,3 @@
+
+#ifdef USE_OMX_TARGET_ZYNQ_USCALE_PLUS
+  /* GOP pattern */

Limitation of the Android API. I added a comment.

@@ +300,3 @@
+  err =
+      gst_omx_component_set_parameter (GST_OMX_VIDEO_ENC (self)->enc,
+      (OMX_INDEXTYPE) OMX_ALG_IndexParamVideoHevc, &param);

The param arg is different so they use another index to make this clearer. I
added a comment and used a #define.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.